Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue that resulted in anonymous leads not getting converted on form submit #1037

Merged
merged 1 commit into from
Oct 22, 2015

Conversation

alanhartless
Copy link
Contributor

Description

If an anonymous lead submitted a form, a new lead was created rather than the anonymous lead being updated. This resulted in things like tags not being applied to the form submission's lead. This fixes #1011.

Testing

  1. Create a form with an email field
  2. Embed the tracking pixel into a 3rd party page with a query of tags=FormTest
  3. Browse to the web page via an anonymous browser
  4. Now browse to the public form submit page (/form/ID) and submit the form with an email not already tracked in Mautic
  5. Login/go back to Mautic -> Manage Leads -> search tag:FormTest is:anonymous and you should see an anonymous lead and note the ID. Then search for the email and should note a separate lead (different ID).

Apply the PR and delete the two leads from above and repeat. This time, the anonymous lead should become the identified lead and keep all tags, etc intact.

… identified on form submit (rather a new identified lead was created)
@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Oct 22, 2015
@alanhartless alanhartless added this to the 1.2.1 milestone Oct 22, 2015
@escopecz
Copy link
Sponsor Member

I have a problem that it doesn't find the lead by tag. I confirmed in the database, that the tag had been created, lead and the tag had been linked. If I search the lead by email, I can see that it has the tag on the lead detail page. But I cannot find the lead by the tag. Doesn't matter if I search in anonymous or identified leads. Am I the only one with this issue?

@escopecz
Copy link
Sponsor Member

But apart form the tag search not working, this PR works fine. I could see in the database that before it created 2 leads and after the PR it creates only one with the correct tag. 👍

@alanhartless
Copy link
Contributor Author

Regarding the tag search, I'm not experiencing that. Could it be a language/translation issue? Or are you using English?

@escopecz
Copy link
Sponsor Member

I used the same example as you described in the testing steps. But it's not related to this PR. It behaves the same in the staging branch as well, so we can merge this PR.

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Oct 22, 2015
dbhurley pushed a commit that referenced this pull request Oct 22, 2015
Fixed issue that resulted in anonymous leads not getting converted on form submit
@dbhurley dbhurley merged commit eef2edb into mautic:staging Oct 22, 2015
@alanhartless alanhartless deleted the tag-lead-merge-fix branch October 30, 2015 04:23
escopecz pushed a commit to escopecz/mautic that referenced this pull request Mar 7, 2024
MAUT 3809 - Use segment membership as a filter for dynamic content for web
escopecz added a commit that referenced this pull request Apr 26, 2024
* MAUT-3602 / Operator list

* Merge pull request #1037 from mautic-inc/MAUT-3809-2

MAUT 3809 - Use segment membership as a filter for dynamic content for web

* Merge pull request #1339 from acquia/MAUT-5498

MAUT-5498 EAB - Segment Membership Filter in Dynamic Content Breaks Landing Pages

* Changes needed after rebase to M5

* CS fixes

* Allow the segment membership filter to be used by DWC

* Test fixes

* Fixing DWC select type filters

---------

Co-authored-by: Lukas Sykora <lukassykora@seznam.cz>
Co-authored-by: Lukáš Drahý <lukas@drahy.net>
Co-authored-by: Rohit Pavaskar <66303837+rohitp19@users.noreply.github.com>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Lead tags disappear from profile when it becomes from anonymous to known lead
3 participants