Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect response event #10503

Draft
wants to merge 28 commits into
base: 4.x
Choose a base branch
from
Draft

Add redirect response event #10503

wants to merge 28 commits into from

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Oct 3, 2021

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

This PR add redirect response event to allow developers extend redirect logic. For example you can add you own page before redirect to page. For example you can display ad or some validation page before go to page.

Steps to test this PR:

  1. Load up this PR

RCheesley and others added 17 commits August 31, 2021 21:42
* Fix points in webhook after form submission

* CS fixer

* Add unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Signed-off-by: Giovanni Mascellani <giovanni@mascellani.eu>

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
* Fix form issues with file type field

* Fix unit tests

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
* Optimizing of loading of forms into a gated video select box

Now we are loading only the ID and label instead of all columns and it will also load only published forms

* Correction of the test folder

* Container has become a static property 🤷

Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
…g is enabled (mautic#9761)

* Add missing properties for custom field responses

* Give option to api controllers to handle saving the entity

* Return 202 (accepted) when fields are processed in the background rather than throwing an uncaught exception

* Added AbstractMauticTestCase::$configParams property

* Removed 'charLengthLimit' from LeadField::loadApiMetadata()

Co-authored-by: Alan Hartless <alan@devkardia.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Co-authored-by: Adrian Schimpf <adrian@idea2.ch>
Co-authored-by: Dennis Ameling (he/him) <dennis@dennisameling.com>
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Oct 3, 2021
@kuzmany kuzmany marked this pull request as draft October 3, 2021 17:14
@kuzmany kuzmany changed the title Add redirect event Add redirect response event Oct 4, 2021
bumping to version 4.0.1
# Conflicts:
#	.php-cs-fixer.php
#	app/bundles/PageBundle/Controller/PublicController.php
#	app/release_metadata.json
#	plugins/GrapesJsBuilderBundle/package-lock.json
@RCheesley RCheesley added the needs-rebase PR's that need to be rebased label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The PR contributors have signed the contributors agreement needs-rebase PR's that need to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants