Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis to DDEV #10538

Merged
merged 4 commits into from Feb 4, 2022
Merged

Add Redis to DDEV #10538

merged 4 commits into from Feb 4, 2022

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Oct 17, 2021 •
edited by gitpod-io bot

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Add Redis for DDEV - your local enviroment based on

Steps to test this PR:

  1. Load up this PR

  2. For new installation run ddev start

  3. For already exist ddev installation run ddev restart

  4. After build you should see Redis Commander on https://mautic.ddev.site:1359/
    image

  5. Your redis instance is available inside the containers at ddev-mautic-redis:6379

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Oct 17, 2021
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Oct 17, 2021
@kuzmany kuzmany added this to the 4.0.2 milestone Oct 17, 2021
@escopecz escopecz added the hacktoberfest-accepted PR's that have been accepted for the purposes of Hacktoberfest label Oct 29, 2021
RCheesley
RCheesley previously approved these changes Nov 11, 2021
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @kuzmany - worked great for me with DDEV restart and I'm sure it will be super helpful for folks using Redis!

🚀

@RCheesley RCheesley added pending-test-confirmation PR's that require one test before they can be merged code-review-needed PR's that require a code review before merging and removed ready-to-test PR's that are ready to test labels Nov 11, 2021
@kuzmany
Copy link
Member Author

kuzmany commented Nov 11, 2021

@dennisameling can you make review of this?

@RCheesley RCheesley modified the milestones: 4.0.2, 4.1 Nov 16, 2021
@RCheesley
Copy link
Sponsor Member

Could you please rebase this against the 4.x branch? Thanks!

@RCheesley RCheesley changed the base branch from 4.0 to 4.x November 23, 2021 15:59
@RCheesley RCheesley dismissed their stale review November 23, 2021 15:59

The base branch was changed.

@RCheesley RCheesley modified the milestones: 4.1, 4.2 Nov 29, 2021
@kuzmany kuzmany mentioned this pull request Jan 29, 2022
Closed
39 tasks
@kuzmany kuzmany changed the base branch from 4.x to 4.0 January 31, 2022 16:40
@kuzmany kuzmany changed the base branch from 4.0 to 4.x January 31, 2022 16:42
@kuzmany kuzmany changed the base branch from 4.x to 4.0 January 31, 2022 16:42
@kuzmany kuzmany changed the base branch from 4.0 to 4.x January 31, 2022 16:44
kuzmany and others added 2 commits January 31, 2022 17:45
@kuzmany @RCheesley
Add no_unused_imports to CS fixer (mautic#10317)
acd5914 
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
@kuzmany
Add Redis for ddev
54e1449
@biozshock
Copy link
Contributor

After applying the patch redis has started with ddev.

@kuzmany
Copy link
Member Author

kuzmany commented Feb 4, 2022

@biozshock thanks for review. Can you use for next PRs review tool in the tab?

image

@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Feb 4, 2022
@RCheesley RCheesley merged commit f91c020 into mautic:4.x Feb 4, 2022
@RCheesley
Copy link
Sponsor Member

@all-contributors please add @biozshock for Review

@allcontributors allcontributors bot mentioned this pull request Feb 4, 2022
Merged
@allcontributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @biozshock! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biozshock biozshock biozshock approved these changes

@RCheesley RCheesley RCheesley left review comments

@dennisameling dennisameling Awaiting requested review from dennisameling

Assignees
No one assigned
Labels
cla-signed The PR contributors have signed the contributors agreement code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality hacktoberfest-accepted PR's that have been accepted for the purposes of Hacktoberfest ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuzmany @RCheesley @biozshock @escopecz