Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix static config file in tests #10810

Merged
merged 7 commits into from Jan 31, 2022
Merged

fix static config file in tests #10810

merged 7 commits into from Jan 31, 2022

Conversation

adiux
Copy link
Contributor

@adiux adiux commented Jan 29, 2022 •
edited by gitpod-io bot

Q A
Bug fix? (use the a.b branch) maybe
New feature/enhancement? (use the a.x branch) no
Deprecations? no
BC breaks? (use the c.x branch) no
Automated tests included? yes
Issue(s) addressed Fixes an issue with automated tests if the config file is not in the default location

Steps to test this PR:

  1. Checkout the code locally
  2. Run automated tests for this
  • composer test -- --filter ConfigControllerFunctionalTest or
  • ddev exec composer test -- --filter ConfigControllerFunctionalTest

(I guess the automated tests that run with each PR should also show if there is a problem with this)

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Jan 29, 2022
@RCheesley RCheesley requested a review from a team January 31, 2022 13:52
@RCheesley RCheesley added automated-tests Anything related to unit, functional or e2e tests bug Issues or PR's relating to bugs labels Jan 31, 2022
@RCheesley RCheesley requested a review from fedys January 31, 2022 13:52
@RCheesley RCheesley added the T1 Low difficulty to fix (issue) or test (PR) label Jan 31, 2022
@RCheesley RCheesley added this to the 4.2 milestone Jan 31, 2022
fedys
fedys requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@fedys fedys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adiux! There is a way to make it a bit simpler. See my code suggestions.

app/bundles/ConfigBundle/Tests/Controller/ConfigControllerFunctionalTest.php Outdated Show resolved Hide resolved
app/bundles/ConfigBundle/Tests/Controller/ConfigControllerFunctionalTest.php Outdated Show resolved Hide resolved
Adrian Schimpf and others added 2 commits January 31, 2022 15:03
@fedys
Update app/bundles/ConfigBundle/Tests/Controller/ConfigControllerFunc…
cfa7583 
…tionalTest.php

Co-authored-by: Miroslav Fedeleš <miroslav.fedeles@gmail.com>
@fedys
Update app/bundles/ConfigBundle/Tests/Controller/ConfigControllerFunc…
f5963f1 
…tionalTest.php

Co-authored-by: Miroslav Fedeleš <miroslav.fedeles@gmail.com>
fedys
fedys approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@fedys fedys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adiux 👍

kuzmany
kuzmany approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuzmany kuzmany added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RCheesley RCheesley merged commit ac770ca into mautic:4.x Jan 31, 2022
shinde-rahul pushed a commit to shinde-rahul/mautic that referenced this pull request Feb 2, 2022
@fedys @RCheesley @shinde-rahul
fix static config file in tests (mautic#10810)
a735235 
* fix static config file in tests

* fix library use order

* Revert "fix library use order"

This reverts commit da19ec5.

* redo: fix library use order

* Update app/bundles/ConfigBundle/Tests/Controller/ConfigControllerFunctionalTest.php

Co-authored-by: Miroslav Fedeleš <miroslav.fedeles@gmail.com>

* Update app/bundles/ConfigBundle/Tests/Controller/ConfigControllerFunctionalTest.php

Co-authored-by: Miroslav Fedeleš <miroslav.fedeles@gmail.com>

Co-authored-by: Miroslav Fedeleš <miroslav.fedeles@gmail.com>
Co-authored-by: Ruth Cheesley <ruth.cheesley@acquia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@fedys fedys fedys approved these changes

Assignees
No one assigned
Labels
automated-tests Anything related to unit, functional or e2e tests bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adiux @kuzmany @fedys @RCheesley