On Email Failed regular mark email as failed

[kuzmany]

Q	A
Bug fix? (use the a.b branch)	[ ]
New feature/enhancement? (use the a.x branch)	[ ]
Deprecations?	[ ]
BC breaks? (use the c.x branch)	[ ]
Automated tests included?	[ ]
Related user documentation PR URL	mautic/mautic-documentation#...
Related developer documentation PR URL	mautic/developer-documentation#...
Issue(s) addressed	Fixes #...

Description:

Steps to test this PR:

On email failed we set contact to DNC.
But failed send email could have a lot of reasons (smtp timeout etc).
Then I suggest mark email as failed and do not set contact as DNC.

1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
2. Hard to tell how to reproduce. Need make failed send email
3. Probably code review and unit tests are enoiught

[codecov]

Codecov Report

Merging #11285 (68ebcd3) into 4.x (9092bbf) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                4.x   #11285      +/-   ##
============================================
+ Coverage     48.87%   48.92%   +0.05%     
+ Complexity    35395    35378      -17     
============================================
  Files          2144     2144              
  Lines        105510   105456      -54     
============================================
+ Hits          51563    51596      +33     
+ Misses        53947    53860      -87     

Impacted Files	Coverage Δ
.../EmailBundle/Swiftmailer/Message/MauticMessage.php	71.42% <ø> (ø)
...dles/EmailBundle/EventListener/EmailSubscriber.php	95.45% <100.00%> (+17.67%)	⬆️
...es/CampaignBundle/EventListener/LeadSubscriber.php	58.69% <0.00%> (-20.52%)	⬇️
...p/bundles/LeadBundle/Entity/LeadListRepository.php	49.32% <0.00%> (-6.79%)	⬇️
...ndles/CampaignBundle/Entity/CampaignRepository.php	56.69% <0.00%> (-4.93%)	⬇️
app/bundles/EmailBundle/Entity/Copy.php	33.33% <0.00%> (-3.81%)	⬇️
app/bundles/UserBundle/Entity/User.php	80.26% <0.00%> (-0.67%)	⬇️
app/bundles/LeadBundle/Model/LeadModel.php	44.40% <0.00%> (-0.32%)	⬇️
app/bundles/IntegrationsBundle/Event/SyncEvent.php	0.00% <0.00%> (ø)
...MauticTagManagerBundle/Form/Type/TagEntityType.php	100.00% <0.00%> (ø)
... and 13 more

[mautibot]

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/failed-email-status-only-after-three-attempts/23522/22

[escopecz]

I think it makes sense. The downside of this approach will be that if the email is failing for some reason like that the email inbox no longer exists then it will send the emails indefinitely. The upside is that this will work nicely with temporary failures.

Can you also write one more test to also test that the email stat was not failed if the stat is not failed? It's always good to test multiple scenarios.

[escopecz]

Can we do something like this:

        $message               = new class() extends \Swift_Message {
            public $leadIdHash = 'some-hash';
        };

Instead of modifying the actual class to make a test work?

[kuzmany]

The downside of this approach will be that if the email is failing for some reason like that the email inbox no longer exists then it will send the emails indefinitely.

This should cover bounce management of each transport.