Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New segment test case #11404

Merged
merged 8 commits into from
Aug 22, 2022
Merged

New segment test case #11404

merged 8 commits into from
Aug 22, 2022

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Aug 18, 2022

Q A
Bug fix? (use the a.b branch) [n]
New feature/enhancement? (use the a.x branch) [n]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [y]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

This test was written by @lukassykora as a "Innovation Day" task and tests some segment filters and edit page.

Steps to test this PR:

  1. No need to test as no production code was changed. Just an automated test was added.

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Aug 18, 2022
@escopecz escopecz requested a review from kuzmany August 18, 2022 11:19
@escopecz escopecz added bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging automated-tests Anything related to unit, functional or e2e tests labels Aug 18, 2022
@escopecz escopecz added this to the 4.4.2 milestone Aug 18, 2022
@escopecz
Copy link
Sponsor Member Author

I'm adding the "bug" label so we can add it to the 4.4.2 release. There is no reason to wait for a minor release with this as stability which this new test is checking is always a good thing.

@kuzmany I'm adding you as a reviewer. I don't think it needs more than 1 approval from a developer to merge this.

Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuzmany kuzmany added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Aug 22, 2022
@kuzmany kuzmany merged commit 24d1434 into mautic:4.4 Aug 22, 2022
@escopecz escopecz deleted the segment-test-case branch August 29, 2022 11:28
@escopecz escopecz removed the code-review-needed PR's that require a code review before merging label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests Anything related to unit, functional or e2e tests bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants