Adding Symfony 4.0 and 4.1 Rector rule sets to CI #11479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
escopecz
force-pushed
the
rector-symfony
branch
from
1bc3c08
to
319076d
Compare
Codecov Report
@@ Coverage Diff @@
## 5.x #11479 +/- ##
=========================================
Coverage 49.91% 49.91%
- Complexity 35511 35515 +4
=========================================
Files 2153 2153
Lines 106392 106392
=========================================
Hits 53102 53102
Misses 53290 53290
|
Error message:
Could not process "app/bundles/IntegrationsBundle/Controller/ConfigController.php" file, due to:
"System error: "Rector\Symfony\Rector\MethodCall\FormIsValidRector::isIsSubmittedByAlreadyCalledOnVariable():
Argument #1 ($variable) must be of type PhpParser\Node\Expr\Variable, PhpParser\Node\Expr\PropertyFetch given,
called in vendor/rector/rector/vendor/rector/rector-symfony/src/Rector/MethodCall/FormIsValidRector.php:59"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On
line: 86
escopecz
changed the title
escopecz
added
bug
mollux
previously approved these changes
Sep 23, 2022
escopecz
added
the
ready-to-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The idea is that we'll have Rector rules that we need to get to Symfony 5 support (refactor the deprecated code) in CI so that all PRs (currently 260 open, kinda old PRs) will not add some deprecated code.
This PR starts with Symfony 4.0 and 4.1 rule set. Symfony 4.2 will follow but we need to merge #11447 first as it focuses on TranslatorInterface and change a lot of files.
I had to refactor
app/bundles/IntegrationsBundle/Controller/ConfigController.phpa little as using property of$this->formover just variable$formwas breaking a Rector rule. It was an anti-pattern anyway as we can simply pass the form as input params to the private methods instead which is much cleaner.The Symfony rule set also needs the cache built so I added
bin/console cache:warmupbefore we run Rector.Steps to test this PR: