Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there is a default db prefix during PHPUnit tests (4.4) #11496

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Sep 23, 2022

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

In #11476 the db prefix was changed to be a fixed string by default.
But in the .env.dist file the MAUTIC_DB_PREFIX env var defaults to an empty string.
So all tests run without a prefix.

Screenshot 2022-09-23 at 10 47 06

This PR ensures the default is also test_

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Sep 23, 2022
@RCheesley RCheesley added the code-review-needed PR's that require a code review before merging label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #11496 (69ba2ec) into 4.4 (6e81e89) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #11496      +/-   ##
============================================
- Coverage     49.36%   49.36%   -0.01%     
  Complexity    35401    35401              
============================================
  Files          2144     2144              
  Lines        105534   105534              
============================================
- Hits          52102    52101       -1     
- Misses        53432    53433       +1     
Impacted Files Coverage Δ
...eBundle/EventListener/DoctrineEventsSubscriber.php 72.72% <0.00%> (-1.82%) ⬇️

@RCheesley RCheesley added the bug Issues or PR's relating to bugs label Sep 23, 2022
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging labels Sep 23, 2022
@escopecz escopecz added this to the 4.4.3 milestone Sep 23, 2022
@escopecz escopecz merged commit e10b465 into mautic:4.4 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants