Segment - Fix filter URL Visited with regex and more #11541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Cr7t3K
force-pushed
the
fix-segment-filter-regex
branch
from
002b04b
to
7f35ae7
Compare
PierreAmmeloot
approved these changes
Oct 5, 2022
npracht
added
bug
1 task
1 task
escopecz
requested changes
Oct 7, 2022
escopecz
added
the
pending-feedback
Codecov Report
@@ Coverage Diff @@
## 4.4 #11541 +/- ##
============================================
+ Coverage 49.54% 50.02% +0.47%
- Complexity 35405 35406 +1
============================================
Files 2144 2144
Lines 105542 105550 +8
============================================
+ Hits 52296 52806 +510
+ Misses 53246 52744 -502
|
escopecz
removed
the
pending-feedback
escopecz
added
ready-to-commit
|
@Cr7t3K create please also PRs with these commits against the 5.x branch. It may need rebase or cherry-pick. See 5.x...Cr7t3K:fix-segment-filter-regex |
escopecz
removed
the
code-review-needed
|
Aha, you already did. #11556 Thank you! |
escopecz
added a commit
to escopecz/mautic
that referenced
this pull request
Nov 2, 2022
escopecz
added a commit
that referenced
this pull request
Nov 7, 2022
* Fix import company error message without unique fields * Fix PHP stan * Change clean conditional values with InputHelper::clean * Fix unit test * Fix error with regex operator * Create functional test for filter with regex * Add test for segment filter with object behaviors * Change the regex of test suit for match with MariaDb 10.3 and MySQL 5.7 * Update SpoolTransport.php * Removing diff from interval and adding initially * Adding typehint to test * CS Fixer changes * Removing Adding interval to grouped contacts * CS fixes * Dynamic Content filters fixed * Dynamic Content filters fixed - return type of test methods specified * Company city filter test with lead and empty company * Removed unnecessary change in error reporting in test * Fix day graph range * Updating queries in the test for #11541 Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz> Co-authored-by: Zdeno Kuzmany <zku@webmecanik.com> Co-authored-by: Guillaume <cguillaumedu85@orange.fr> Co-authored-by: Tony Eckstrand <teckstrand@lawdepot.com> Co-authored-by: jazeabby <abhishek.jain@acquia.com> Co-authored-by: Anna Munk <anna.munk@comarch.pl>
mautibot
pushed a commit
to mautic/core-lib
that referenced
this pull request
Nov 7, 2022
* Fix import company error message without unique fields * Fix PHP stan * Change clean conditional values with InputHelper::clean * Fix unit test * Fix error with regex operator * Create functional test for filter with regex * Add test for segment filter with object behaviors * Change the regex of test suit for match with MariaDb 10.3 and MySQL 5.7 * Update SpoolTransport.php * Removing diff from interval and adding initially * Adding typehint to test * CS Fixer changes * Removing Adding interval to grouped contacts * CS fixes * Dynamic Content filters fixed * Dynamic Content filters fixed - return type of test methods specified * Company city filter test with lead and empty company * Removed unnecessary change in error reporting in test * Fix day graph range * Updating queries in the test for mautic/mautic#11541 Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz> Co-authored-by: Zdeno Kuzmany <zku@webmecanik.com> Co-authored-by: Guillaume <cguillaumedu85@orange.fr> Co-authored-by: Tony Eckstrand <teckstrand@lawdepot.com> Co-authored-by: jazeabby <abhishek.jain@acquia.com> Co-authored-by: Anna Munk <anna.munk@comarch.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the problem with regex filters, like the visited url.
The filter did not take into account the regex, and display the same number of contacts no matter the regex.
Steps to test this PR:
PR funded by @PierreAmmeloot from WebAnyOne