Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade php cs fixer #11548

Merged
merged 4 commits into from Oct 12, 2022
Merged

Upgrade php cs fixer #11548

merged 4 commits into from Oct 12, 2022

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ x ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]

Description:

Upgraded codestyle checker PHP-CS-Fixer to latest version.

Steps to test this PR:

  1. See github actions are not failing.
  2. Do a code review.

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #11548 (598b25e) into 5.x (024d80c) will not change coverage.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##                5.x   #11548   +/-   ##
=========================================
  Coverage     51.50%   51.50%           
- Complexity    35373    35375    +2     
=========================================
  Files          2144     2144           
  Lines        106485   106485           
=========================================
  Hits          54842    54842           
  Misses        51643    51643           
Impacted Files Coverage Δ
...m/Validator/Constraints/OAuthCallbackValidator.php 50.00% <ø> (ø)
app/bundles/ApiBundle/Model/ClientModel.php 70.21% <ø> (ø)
...ndles/AssetBundle/EventListener/FormSubscriber.php 25.00% <0.00%> (ø)
...les/AssetBundle/EventListener/ReportSubscriber.php 56.52% <ø> (ø)
app/bundles/CampaignBundle/Entity/Event.php 80.45% <ø> (ø)
...ntListener/CampaignActionJumpToEventSubscriber.php 85.71% <ø> (ø)
.../CampaignBundle/EventListener/ReportSubscriber.php 15.11% <ø> (ø)
...aignBundle/Executioner/Event/ActionExecutioner.php 84.61% <ø> (ø)
...nBundle/Executioner/Event/ConditionExecutioner.php 94.44% <ø> (ø)
...gnBundle/Executioner/Event/DecisionExecutioner.php 33.33% <ø> (ø)
... and 126 more

escopecz
escopecz previously approved these changes Oct 7, 2022
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about this change as this will cause a lot of open PRs to have conflicts and require manual work to get them into mergeable state. When releasing M4 release we have to merge the changes to the 5.x branch which is costly already. Last time I had to resolve around 100 conflicting files. I would appreciate if we wouldn't make it any harder.

On the other hand, we did the same on our fork and it is the way forward. So Let's not stop the progress.

@kuzmany what do you think?

@escopecz escopecz requested a review from kuzmany October 7, 2022 07:52
@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged enhancement Any improvement to an existing feature or functionality labels Oct 7, 2022
@escopecz escopecz self-assigned this Oct 12, 2022
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this to fix a conflict in composer.lock. I better merge this to avoid other conflicts.

@escopecz escopecz added this to the 5.0-alpha milestone Oct 12, 2022
@escopecz escopecz merged commit 353e377 into mautic:5.x Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The PR contributors have signed the contributors agreement enhancement Any improvement to an existing feature or functionality pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants