New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade php cs fixer #11548
Upgrade php cs fixer #11548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feelings about this change as this will cause a lot of open PRs to have conflicts and require manual work to get them into mergeable state. When releasing M4 release we have to merge the changes to the 5.x branch which is costly already. Last time I had to resolve around 100 conflicting files. I would appreciate if we wouldn't make it any harder.
On the other hand, we did the same on our fork and it is the way forward. So Let's not stop the progress.
@kuzmany what do you think?
7e4b6f2
to
598b25e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased this to fix a conflict in composer.lock. I better merge this to avoid other conflicts.
Description:
Upgraded codestyle checker
PHP-CS-Fixer
to latest version.Steps to test this PR: