Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for UI installer to ensure basic config works (4.4) #11559

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Oct 8, 2022

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [x]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

see #11557
this PR is for the 4.4 branch

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Oct 8, 2022
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #11559 (ef6efd3) into 4.4 (4c947e9) will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #11559      +/-   ##
============================================
+ Coverage     49.54%   50.02%   +0.47%     
  Complexity    35405    35405              
============================================
  Files          2144     2144              
  Lines        105542   105546       +4     
============================================
+ Hits          52296    52795     +499     
+ Misses        53246    52751     -495     
Impacted Files Coverage Δ
...Bundle/EventListener/GeneratedColumnSubscriber.php 92.30% <0.00%> (-7.70%) ⬇️
...p/bundles/InstallBundle/Command/InstallCommand.php 70.55% <0.00%> (-0.73%) ⬇️
...es/IntegrationsBundle/Sync/SyncJudge/SyncJudge.php 0.00% <0.00%> (ø)
...dles/CoreBundle/Templating/Helper/AssetsHelper.php 72.40% <0.00%> (+2.86%) ⬆️
...dles/InstallBundle/Configurator/Step/CheckStep.php 58.33% <0.00%> (+4.16%) ⬆️
app/bundles/ReportBundle/Entity/Report.php 81.18% <0.00%> (+4.95%) ⬆️
...ugins/GrapesJsBuilderBundle/Integration/Config.php 66.66% <0.00%> (+13.33%) ⬆️
app/bundles/CoreBundle/Event/CustomAssetsEvent.php 44.44% <0.00%> (+18.51%) ⬆️
...BuilderBundle/EventSubscriber/AssetsSubscriber.php 100.00% <0.00%> (+27.27%) ⬆️
app/bundles/InstallBundle/Helper/SchemaHelper.php 71.01% <0.00%> (+27.53%) ⬆️
... and 18 more

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@escopecz escopecz added this to the 4.4.4 milestone Oct 10, 2022
@escopecz escopecz added bug Issues or PR's relating to bugs automated-tests Anything related to unit, functional or e2e tests labels Oct 10, 2022
@escopecz escopecz merged commit 960e9e6 into mautic:4.4 Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests Anything related to unit, functional or e2e tests bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants