Campaign events reschedules due to DST

[rohitpavaskar]

Q	A
Bug fix? (use the a.b branch)	[Y]
New feature/enhancement? (use the a.x branch)	[N]
Deprecations?	[N]
BC breaks? (use the c.x branch)	[N]
Automated tests included?	[Y]
Related user documentation PR URL	mautic/mautic-documentation#...
Related developer documentation PR URL	mautic/developer-documentation#...
Issue(s) addressed	Fixes #...

Description:
Campaign events can get stuck in an hourly rescheduling loop with the following circumstances:

The event was evaluated prior to a time change that falls back an hour to be executed at a time after the time change. E.g. date_triggered = 2021-10-24 17:00:00 and trigger_date = 2021-11-08 14:00:00.
The event is scheduled at a relative time period at a specific hour or between two hours.

Steps to test this PR:
Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
Create a campaign with event which can be scheduled after 7th November 2021.
Add a contact in Eastern time zone where DST changes are applicable and add that contact to the segment which used in above campaign.
Change date_triggered date in mautic_campaign_lead_event_log to befoe DST 7th November 2021. and verify event get triggered at correct time

[codecov]

Codecov Report

Merging #11602 (bdeb906) into 4.4 (18ec528) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                4.4   #11602   +/-   ##
=========================================
  Coverage     49.96%   49.96%           
- Complexity    35405    35407    +2     
=========================================
  Files          2144     2144           
  Lines        106296   106295    -1     
=========================================
+ Hits          53109    53114    +5     
+ Misses        53187    53181    -6     

Impacted Files	Coverage Δ
...aignBundle/Executioner/Scheduler/Mode/Interval.php	91.36% <100.00%> (+4.22%)	⬆️

[escopecz]

I merged this by accident. Too many tabs opened. I'll give it a test now.

[escopecz]

@rohitp19 can you please help me with the last step?

Change date_triggered date in mautic_campaign_lead_event_log to befoe DST 7th November 2021. and verify event get triggered at correct time

The date_triggered is already stet to today. Which is before DST change. If I change the trigger_date and then run bin/console m:c:t then it will schedule it back to the date after DST change set in the campaign event. What am I missing?

[rohitp19]

@rohitp19 can you please help me with the last step?

Change date_triggered date in mautic_campaign_lead_event_log to befoe DST 7th November 2021. and verify event get triggered at correct time

The date_triggered is already stet to today. Which is before DST change. If I change the trigger_date and then run bin/console m:c:t then it will schedule it back to the date after DST change set in the campaign event. What am I missing?

This condition can be tested when server current time is outside DST and date_triggered inside DST