Add orderBy to findOneBy to return more accurate eventLog result #11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Codecov Report
@@ Coverage Diff @@
## 4.4 #11636 +/- ##
============================================
+ Coverage 49.33% 49.97% +0.63%
- Complexity 35395 35408 +13
============================================
Files 2144 2144
Lines 105524 106299 +775
============================================
+ Hits 52056 53118 +1062
+ Misses 53468 53181 -287
|
kuzmany
added
the
pending-test-confirmation
21 tasks
22 tasks
|
@pwned555 thank you. |
beetofly
approved these changes
Nov 4, 2022
volha-pivavarchyk
approved these changes
Nov 4, 2022
25 tasks
22 tasks
RCheesley
added
ready-to-commit
|
@pwned555 please can you make a duplicate PR on the 5.x branch then this is good to be merged for the release. Thanks! |
RCheesley
added
the
pending-companion-pr
|
Bumping this from the release until we have the 5.x PR to merge alongside. |
mabumusa1
removed
pending-test-confirmation
|
@escopecz this is ready now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes issue with wrong eventLog record being returned when trying to cancel if the user has multiple records with the same eventId.
Steps to test this PR:
Step 1: Create a Campaign that allows users to restart it
Step 2: In that Campaign create an event with a 1 hour delay that removes the user from the Campaign
Step 3: Have user go on Campaign and wait for the user to be removed and event to be fired
Step 4: Have user go on Campaign again, this time try to cancel the event before 1 hour. It should allow you to cancel the event.