Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marketing message sorting by category (v4.x) #11733

Conversation

volha-pivavarchyk
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

This PR duplicates 11725 for v 4.x

Steps to test this PR:

  1. Create two or three marketing messages.
  2. Try to sort by column
  3. There is an error.
  4. Swich on the other page, e.g. emails
  5. Try to open the marketing messages page again
  6. Not opening

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create two or three marketing messages.
  3. Try to sort by column.
  4. Sorting works well.

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #11733 (fed5495) into 4.4 (c24e804) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                4.4   #11733   +/-   ##
=========================================
  Coverage     50.00%   50.00%           
  Complexity    35411    35411           
=========================================
  Files          2144     2144           
  Lines        106304   106305    +1     
=========================================
+ Hits          53153    53154    +1     
  Misses        53151    53151           
Impacted Files Coverage Δ
...bundles/ChannelBundle/Entity/MessageRepository.php 15.90% <100.00%> (+1.95%) ⬆️

@RCheesley RCheesley added bug Issues or PR's relating to bugs marketing-messages ready-to-test PR's that are ready to test labels Nov 22, 2022
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, works as expected on 4.4 🚀

@escopecz escopecz added this to the 4.4.6 milestone Dec 2, 2022
@escopecz escopecz merged commit 9fe3328 into mautic:4.4 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement marketing-messages ready-to-test PR's that are ready to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants