Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving Hubspot Mapping Error #11753

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Resolving Hubspot Mapping Error #11753

merged 1 commit into from
Nov 30, 2022

Conversation

onairmarc
Copy link
Contributor

This PR implements the fix discussed in this Mautic Community Forum Thread: https://forum.mautic.org/t/hubspot-mapping-error/25711

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Nov 25, 2022
@onairmarc
Copy link
Contributor Author

@RCheesley This is the PR that replaces the PR on 4.x. Please let me know if you need anything else from me.

RCheesley
RCheesley approved these changes Nov 29, 2022
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked perfectly for me, I was able to set up the HubSpot plugin and switch between the different tabs, which I can't do with the current mautic/mautic 4.4.4 release.

I also set up the Salesforce integration to make sure that the pagination still worked there, and it does!

Thanks @onairmarc for making the PR!

🚀

@RCheesley RCheesley added pending-test-confirmation PR's that require one test before they can be merged bug Issues or PR's relating to bugs plugin Anything related to plugins labels Nov 29, 2022
@RCheesley RCheesley added this to the 4.4.5 milestone Nov 29, 2022
@RCheesley
Copy link
Sponsor Member

@onairmarc if you have the capacity can you create this on the 5.x branch as well (just an exact duplicate of this PR), so that it makes it into both the 4.4.5 and the 5.0 alpha release? Should be quick to test and merge hopefully as it's super easy to test! Thanks so much! 🚀

@RCheesley RCheesley added the pending-companion-pr Waiting for the author to create a PR on the other branch. label Nov 29, 2022
@onairmarc
Copy link
Contributor Author

Sure thing! I'll have time this evening to do this.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #11753 (3e6e968) into 4.4 (56e6980) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #11753      +/-   ##
============================================
- Coverage     49.97%   49.97%   -0.01%     
  Complexity    35424    35424              
============================================
  Files          2145     2145              
  Lines        106358   106358              
============================================
- Hits          53153    53152       -1     
- Misses        53205    53206       +1
Impacted Files Coverage Δ
...bundles/PluginBundle/Controller/AjaxController.php 0.00% <0.00%> (ø)
...bundles/LeadBundle/Controller/ImportController.php 59.55% <0.00%> (-0.32%) ⬇️

@onairmarc onairmarc mentioned this pull request Nov 30, 2022
Merged
@onairmarc
Copy link
Contributor Author

@RCheesley PR #11761 submitted for Mautic 5.x

biozshock
biozshock approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@biozshock biozshock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm this works. Did the same but for all affected places in #11760

@RCheesley
Copy link
Sponsor Member

The file causing a reduction in coverage is not related to this PR so going to go ahead and merge.

@RCheesley RCheesley added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Nov 30, 2022
@RCheesley RCheesley merged commit 861e1c7 into mautic:4.4 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biozshock biozshock biozshock approved these changes

@RCheesley RCheesley RCheesley approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement pending-companion-pr Waiting for the author to create a PR on the other branch. plugin Anything related to plugins ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
4.4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onairmarc @RCheesley @biozshock