Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The contact history item "UTM tags recorded" has a clearer event label #11754

Merged
merged 1 commit into from Dec 6, 2022
Merged

The contact history item "UTM tags recorded" has a clearer event label #11754

merged 1 commit into from Dec 6, 2022

Conversation

volha-pivavarchyk
Copy link
Contributor

@volha-pivavarchyk volha-pivavarchyk commented Nov 28, 2022 •
edited

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

This PR contains a small change and makes the "UTM tags recorded" contact history item label clearer.

now
image
before
image

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Add utm tags to lead.
  3. Check the lead timeline. There is "UTM Campaign: " instead of "".

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Nov 28, 2022
npracht
npracht approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #11754 (3b6a51c) into 5.x (48e540b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                5.x   #11754   +/-   ##
=========================================
  Coverage     52.32%   52.32%           
  Complexity    35595    35595           
=========================================
  Files          2189     2189           
  Lines        107148   107148           
=========================================
  Hits          56061    56061           
  Misses        51087    51087
Impacted Files Coverage Δ
...undles/LeadBundle/EventListener/LeadSubscriber.php 65.31% <0.00%> (ø)

escopecz
escopecz approved these changes Dec 6, 2022
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@escopecz escopecz added this to the 5.0-alpha milestone Dec 6, 2022
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Dec 6, 2022
@escopecz escopecz merged commit 38898da into mautic:5.x Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
cla-signed The PR contributors have signed the contributors agreement enhancement Any improvement to an existing feature or functionality
Projects
None yet
Milestone
5.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@volha-pivavarchyk @escopecz @npracht