Fix: Dynamic Content in emails (legacy builder)- default content is not saved properly

[irfanhanfi]

Q	A
Bug fix? (use the a.b branch)	[4.x]
New feature/enhancement? (use the a.x branch)	[ ]
Deprecations?	[ ]
BC breaks? (use the c.x branch)	[ ]
Automated tests included?	[ ]
Related user documentation PR URL	mautic/mautic-documentation#...
Related developer documentation PR URL	mautic/developer-documentation#...
Issue(s) addressed	Fixes #11788

Description:

This PR is to fix the issue mentioned here - #11788

[MadlenF]

Works as expected from user-perpective!

[kuzmany]

Works for me 👍
Just app.js should not be part of the PR. It's regenerated during the release process.

[beschulz]

I believe this fix is faulty for html content. We experienced a double escaping issue. Doing the following resolved this:

        if (dynConContent.data('froala.editor') && Mautic.getActiveBuilderName() === 'legacy') {
            dynConContent = dynConContent.froalaEditor('html.get');
        } else {
            dynConContent = dynConContent.text();
        }

(i.e. using .text() instead of .html().

The way I understand the procedure here is that during init (when the initial html is build from the template) dynConContent isn't yet a froalaEditor - but it does have the ".editor" class. Insepcting the DOM revealed that the content from the database was inserted into the DOM as text, not html. I have the suspicion that this is the actual problem for the double escape and that my proposed fix just plasters over the cracks.

[mabumusa1]

@irfanhanfi thank you for this PR, there is a feedback, I think it is worth considering

[irfan-synerzip]

@irfanhanfi thank you for this PR, there is a feedback, I think it is worth considering

I have addressed that change.

[beschulz]

@irfan-synerzip thanks a lot. Although I wonder if this breaks the grapejs stuff. Maybe the whole block should be:

if (Mautic.getActiveBuilderName() === 'legacy') {
    if (dynConContent.data('froala.editor')){
        dynConContent = dynConContent.froalaEditor('html.get');
    } else {
        dynConContent = dynConContent.text();
    }
} else {
    dynConContent = dynConContent.html();
}

[irfan-synerzip]

@beschulz I did not see the issue with the GrapesJS editor but your approach looks safer. I have made the changes as per the latest comment.

Thank you!

[mabumusa1]

I tested this PR and rebased it to 4.4, it looks goo to be merged

[mabumusa1]

@allcontributors please add @irfanhanfi for code

[allcontributors]

@mabumusa1

I've put up a pull request to add @irfanhanfi! 🎉