Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing API test on PHP 8 #11957

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Fix failing API test on PHP 8 #11957

merged 1 commit into from
Feb 11, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Feb 11, 2023

Q A
Bug fix? (use the a.b branch) [ x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

in #11873 an issue was fixed that was discovered when switching the API tests to PHP 8.0.
This fix was not backported to 4.4, so the issue still exists for Mautic 4 on PHP 8

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Feb 11, 2023
@mabumusa1 mabumusa1 added this to the 4.4.7 milestone Feb 11, 2023
@mabumusa1 mabumusa1 self-requested a review February 11, 2023 16:52
@mabumusa1 mabumusa1 added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged code-review-needed PR's that require a code review before merging labels Feb 11, 2023
mabumusa1
mabumusa1 approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is the same as the one we have for 5.x, this PR is good to go

@mabumusa1 mabumusa1 merged commit 030111e into mautic:4.4 Feb 11, 2023
@mollux mollux deleted the backport-11873 branch February 11, 2023 17:00
@escopecz escopecz added the bug Issues or PR's relating to bugs label Mar 9, 2023
@RCheesley RCheesley changed the title backport of PR 11873 to ensure we can test API Fix failing API test on PHP 8 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabumusa1 mabumusa1 mabumusa1 approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement code-review-needed PR's that require a code review before merging ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
4.4.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mollux @mabumusa1 @escopecz