Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get request variables from query instead of request. #12002

Merged
merged 1 commit into from Mar 28, 2023

Conversation

irfan-synerzip
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #11996

Description:

Cherry picking #11760 changes to fix the issue for Mautic 4.4

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Feb 21, 2023
@RCheesley RCheesley mentioned this pull request Feb 24, 2023
21 tasks
@mabumusa1 mabumusa1 mentioned this pull request Mar 3, 2023
48 tasks
@RCheesley RCheesley mentioned this pull request Mar 10, 2023
49 tasks
@RCheesley RCheesley mentioned this pull request Mar 24, 2023
55 tasks
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes make sense. They are same as in the M5 PR and there is no reason they would work differently

@escopecz escopecz added the bug Issues or PR's relating to bugs label Mar 28, 2023
@escopecz escopecz added this to the 4.4.8 milestone Mar 28, 2023
@escopecz
Copy link
Sponsor Member

re-opening to trigger CI jobs

@escopecz escopecz closed this Mar 28, 2023
@escopecz escopecz reopened this Mar 28, 2023
@escopecz escopecz added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #12002 (c8cf33c) into 4.4 (853c13b) will increase coverage by 0.02%.
The diff coverage is 13.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #12002      +/-   ##
============================================
+ Coverage     50.26%   50.29%   +0.02%     
- Complexity    35432    35446      +14     
============================================
  Files          2145     2145              
  Lines        106366   106420      +54     
============================================
+ Hits          53470    53524      +54     
  Misses        52896    52896              
Impacted Files Coverage Δ
...p/bundles/LeadBundle/Controller/AjaxController.php 6.69% <0.00%> (ø)
...bundles/PluginBundle/Controller/AjaxController.php 0.00% <0.00%> (ø)
.../bundles/EmailBundle/Controller/AjaxController.php 32.00% <66.66%> (ø)

... and 2 files with indirect coverage changes

@escopecz escopecz merged commit 6072e36 into mautic:4.4 Mar 28, 2023
18 checks passed
@irfanhanfi irfanhanfi deleted the request-to-query branch March 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants