Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test speed of campaign count tests (backport 4.4) #12158

Merged
merged 1 commit into from Apr 3, 2023
Merged

improve test speed of campaign count tests (backport 4.4) #12158

merged 1 commit into from Apr 3, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Apr 2, 2023 •
edited

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [x]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

backport of #12127 to improve test speed.

see #12127 and #12157 for the why and how

before:
https://github.com/mautic/mautic/actions/runs/4551975555

Screenshot 2023-04-02 at 21 19 12

after:
https://github.com/mautic/mautic/actions/runs/4590327485

Screenshot 2023-04-02 at 21 19 01

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Apr 2, 2023
escopecz
escopecz approved these changes Apr 3, 2023
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of energy saving right here. Thank you! 💚

@escopecz escopecz added this to the 4.4.8 milestone Apr 3, 2023
@escopecz escopecz added performance-scalability Anything related to performance and scalability automated-tests Anything related to unit, functional or e2e tests labels Apr 3, 2023
@escopecz escopecz merged commit 9efec07 into mautic:4.4 Apr 3, 2023
19 checks passed
@RCheesley RCheesley added the enhancement Any improvement to an existing feature or functionality label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
automated-tests Anything related to unit, functional or e2e tests cla-signed The PR contributors have signed the contributors agreement enhancement Any improvement to an existing feature or functionality performance-scalability Anything related to performance and scalability
Projects
None yet
Milestone
4.4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mollux @escopecz @RCheesley