Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPROD-374: Updated testcase to fix DomCrawler::text() passing second argument false. #12179

Merged
merged 3 commits into from Apr 6, 2023
Merged

TPROD-374: Updated testcase to fix DomCrawler::text() passing second argument false. #12179

merged 3 commits into from Apr 6, 2023

Conversation

shinde-rahul
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Resolves these deprecation notices:

6x: "Symfony\Component\DomCrawler\Crawler::text()" will normalize whitespaces by default in Symfony 5.0, set the second "$normalizeWhitespace" argument to false to retrieve the non-normalized version of the text.
    1x in EmailControllerFunctionalTest::testEmailDetailsPageShouldNotHavePendingCount from Mautic\EmailBundle\Tests\Controller
    1x in PublicControllerFunctionalTest::testContactPreferencesSaveMessage from Mautic\EmailBundle\Tests\Controller
    1x in LeadControllerTest::testRetrieveLeadListsBasedOnCategory from Mautic\LeadBundle\Tests\Controller
    1x in ImportControllerFunctionalTest::testScheduleImport from Mautic\LeadBundle\Tests\Functional\Controller
    1x in ImportControllerFunctionalTest::testImportCSVWithFileAsHeaderName from Mautic\LeadBundle\Tests\Functional\Controller
    1x in TagControllerTest::testNewActionDuplicateTag from MauticPlugin\MauticTagManagerBundle\Tests\Functional\Controller

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Apr 6, 2023
mabumusa1
mabumusa1 previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, thanks @shinde-rahul

mabumusa1
mabumusa1 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve, code looks good

@mabumusa1
Copy link
Member

@escopecz this is ready

@escopecz escopecz merged commit c2fbceb into mautic:5.x Apr 6, 2023
12 checks passed
@escopecz escopecz added this to the 5.0-alpha milestone Apr 6, 2023
@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Apr 6, 2023
@mabumusa1
Copy link
Member

Hello @shinde-rahul

Please check the test results, there are still some files that needs your attention

https://github.com/mautic/mautic/actions/runs/4626507129/jobs/8183324789#step:10:1

@shinde-rahul
Copy link
Contributor Author

@mabumusa1, Those are already covered. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabumusa1 mabumusa1 mabumusa1 approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
5.0-alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shinde-rahul @mabumusa1 @escopecz