Modernizr update #12402
Merged
Modernizr update #12402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.x #12402 +/- ##
============================================
+ Coverage 56.27% 56.31% +0.04%
- Complexity 35131 35174 +43
============================================
Files 2209 2209
Lines 105431 105527 +96
============================================
+ Hits 59328 59425 +97
+ Misses 46103 46102 -1
|
escopecz
added
enhancement
mabumusa1
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We were using a Modernizr JS library v2.8.3 that was not published on NPM. Meaning we wouldn't be getting security vulnerability warnings if there would be some.
I'm updating the library to latest v 3.12.0 and loading it from NPM in this PR.
I was also going through all the modules we had in our custom Modernizr build and found only 2 that we actually use.
All the Modernizr checks we were loading:
All the Modernizr checks we are using:
Modernizr was a dependency of the Adminre UI that we are using as Mautic administration UI.
The
touch/no-touchclasses were used but the check was renamed totouchevents/no-toucheventsin v 3. See https://modernizr.com/news/modernizr-3-new-release-site. So I updated usages for those too.Modernizr must be custom-build so I added a
post-installcommand topackage.jsonthat will build our custom Modernizr build according to themodernizr-config.jsonconfig file. There is no extra step that needs to be taken. The build is done automatically during thenpm installcommand and that is being called automatically during thecomposer installcommand.Steps to test this PR:
composer installbin/console mautic:assets:generate<html>tag has these classes:It can have more classes but these are the ones that we need.