Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure the elfinder paths are within the default firewall, so rememberme functionality works (backport) #12433

Merged
merged 1 commit into from Jun 5, 2023
Merged

ensure the elfinder paths are within the default firewall, so rememberme functionality works (backport) #12433

merged 1 commit into from Jun 5, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Jun 5, 2023

backport of #12406 for 4.4

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@mollux mollux requested review from escopecz and fedys June 5, 2023 13:51
@mollux mollux added mautic-4 Relates to Mautic 4.x bug Issues or PR's relating to bugs labels Jun 5, 2023
fedys
fedys approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@fedys fedys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mollux mollux changed the title ensure the elfinder paths are within the default firewall, so rememberme functionality works ensure the elfinder paths are within the default firewall, so rememberme functionality works (backport) Jun 5, 2023
escopecz
escopecz approved these changes Jun 5, 2023
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@escopecz escopecz added this to the 4.4.10 milestone Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #12433 (498f2c6) into 4.4 (74ce8d7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                4.4   #12433   +/-   ##
=========================================
  Coverage     50.29%   50.29%           
  Complexity    35448    35448           
=========================================
  Files          2145     2145           
  Lines        106431   106431           
=========================================
+ Hits          53527    53528    +1     
+ Misses        52904    52903    -1

see 1 file with indirect coverage changes

@escopecz escopecz merged commit 5a48b51 into mautic:4.4 Jun 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@fedys fedys fedys approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs mautic-4 Relates to Mautic 4.x
Projects
None yet
Milestone
4.4.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mollux @escopecz @fedys