Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure only leads from a company are shown on a the company detail overview - 4.4 #12466

Merged
merged 2 commits into from Jun 20, 2023
Merged

ensure only leads from a company are shown on a the company detail overview - 4.4 #12466

merged 2 commits into from Jun 20, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Jun 11, 2023

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

backport of #12464

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@mollux mollux added bug Issues or PR's relating to bugs companies Anything related to companies mautic-4 Relates to Mautic 4.x labels Jun 11, 2023
@mollux mollux changed the title ensure only leads from a company are showed on a the company detail overview ensure only leads from a company are shown on a the company detail overview - 4.4 Jun 11, 2023
@codecov
Copy link

codecov bot commented Jun 11, 2023 •
edited

Codecov Report

Merging #12466 (d050597) into 4.4 (8d43a7f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #12466      +/-   ##
============================================
- Coverage     50.29%   50.28%   -0.02%     
+ Complexity    35448    35446       -2     
============================================
  Files          2145     2145              
  Lines        106431   106426       -5     
============================================
- Hits          53528    53513      -15     
- Misses        52903    52913      +10
Impacted Files Coverage Δ
...undles/LeadBundle/Controller/CompanyController.php 57.62% <100.00%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

@RCheesley RCheesley mentioned this pull request Jun 12, 2023
Merged
@mollux
Copy link
Contributor Author

mollux commented Jun 14, 2023

Fix was confirmed by issue opener in #12415 (comment)

escopecz
escopecz approved these changes Jun 20, 2023
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code makes sense 👍

@escopecz escopecz added this to the 4.4.10 milestone Jun 20, 2023
@escopecz escopecz merged commit 8e728f2 into mautic:4.4 Jun 20, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs companies Anything related to companies mautic-4 Relates to Mautic 4.x
Projects
None yet
Milestone
4.4.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mollux @escopecz