Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPSTAN and Rector updates + baseline update #12531

Merged
merged 3 commits into from Jul 11, 2023

Conversation

escopecz
Copy link
Sponsor Member

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [y]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

There should be more speed improvements for the new PHPSTAN and Rector versions. So pushing the update. Ya know, to save the planet.

Steps to test this PR:

  1. Check that the build is green

@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Jun 29, 2023
@escopecz escopecz added this to the 5.0-beta milestone Jun 29, 2023
@escopecz escopecz requested a review from mabumusa1 June 29, 2023 15:20
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #12531 (d7c9b16) into 5.x (4af87ed) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d7c9b16 differs from pull request most recent head fd7ebfb. Consider uploading reports for the commit fd7ebfb to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12531      +/-   ##
============================================
- Coverage     57.27%   57.27%   -0.01%     
  Complexity    33529    33529              
============================================
  Files          2163     2163              
  Lines        101324   101324              
============================================
- Hits          58031    58030       -1     
- Misses        43293    43294       +1     

see 1 file with indirect coverage changes

@escopecz escopecz requested a review from mollux July 10, 2023 15:06
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@mabumusa1 mabumusa1 added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jul 11, 2023
@escopecz escopecz merged commit 162874d into mautic:5.x Jul 11, 2023
9 of 12 checks passed
@mollux
Copy link
Contributor

mollux commented Jul 11, 2023

@escopecz really cool! I saw the release of Rector, and saw the possibilities that it brings.

@escopecz escopecz deleted the phpstan-rector-update branch July 11, 2023 12:31
@mollux
Copy link
Contributor

mollux commented Jul 12, 2023

@escopecz @mabumusa1 This seems to be merged with a failing PHPSTAN tests, see the checks.
This impacts all current PR's against 5.x

@escopecz escopecz mentioned this pull request Jul 12, 2023
@escopecz
Copy link
Sponsor Member Author

@mollux thanks for calling this out. Fixed in #12556

@mautibot
Copy link

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-5-beta-now-available-for-testing/29764/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants