New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPSTAN and Rector updates + baseline update #12531
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.x #12531 +/- ##
============================================
- Coverage 57.27% 57.27% -0.01%
Complexity 33529 33529
============================================
Files 2163 2163
Lines 101324 101324
============================================
- Hits 58031 58030 -1
- Misses 43293 43294 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good
@escopecz @mabumusa1 This seems to be merged with a failing PHPSTAN tests, see the checks. |
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/announcing-mautic-5-beta-now-available-for-testing/29764/1 |
Description:
There should be more speed improvements for the new PHPSTAN and Rector versions. So pushing the update. Ya know, to save the planet.
Steps to test this PR: