Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching contact import to finish in background causes 500 #12538

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

nick-vanpraet
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ x ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

When starting a contact import via the web browser, and then you click "finish in background", a 500 error occurs. This is because of an extra $ that snuck in a while back.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Import contacts via CSV, make sure there's enough that it takes a while
  3. Hit "finish in background". Should no longer 500 in network tab

@nick-vanpraet
Copy link
Contributor Author

This was already fixed for 5.x btw

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #12538 (bed041e) into 4.4 (8e728f2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #12538      +/-   ##
============================================
- Coverage     50.28%   50.28%   -0.01%     
  Complexity    35447    35447              
============================================
  Files          2145     2145              
  Lines        106426   106426              
============================================
- Hits          53513    53512       -1     
- Misses        52913    52914       +1     
Impacted Files Coverage Δ
...bundles/LeadBundle/Controller/ImportController.php 59.55% <0.00%> (-0.32%) ⬇️

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@escopecz escopecz added bug Issues or PR's relating to bugs import-export Anything related to importing and exporting labels Jul 19, 2023
@escopecz escopecz added this to the 5.0-beta milestone Jul 19, 2023
@escopecz escopecz merged commit 0d57617 into mautic:4.4 Jul 19, 2023
17 of 18 checks passed
@nick-vanpraet nick-vanpraet deleted the bugfix/broken-import-queue branch July 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs import-export Anything related to importing and exporting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants