Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add missing commit to fix incorrect reporting dates #12541

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Jul 6, 2023

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

in #11256 a bug was fixed and merged into 4.3
Somehow that commit was never merged in 4.4, so that bug still exists in the latest 4.4 releases

Looking at the history of the 4.3 branch, it looks like that was the last commit of that branch, so I assume it's the only missing one.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@mollux mollux requested review from kuzmany and escopecz July 6, 2023 14:47
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #12541 (bc10586) into 4.4 (b6fd0be) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.4   #12541      +/-   ##
============================================
+ Coverage     50.17%   50.33%   +0.15%     
- Complexity    35428    35447      +19     
============================================
  Files          2145     2145              
  Lines        106364   106426      +62     
============================================
+ Hits          53369    53569     +200     
+ Misses        52995    52857     -138     

see 27 files with indirect coverage changes

@mollux mollux requested a review from mabumusa1 July 7, 2023 08:33
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@escopecz escopecz added this to the 4.4.10 milestone Jul 10, 2023
@escopecz escopecz added the bug Issues or PR's relating to bugs label Jul 10, 2023
@escopecz escopecz merged commit 5c4a0ff into mautic:4.4 Jul 10, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants