Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects twig templates to use basic html in form help text #12562

Conversation

volha-pivavarchyk
Copy link
Contributor

@volha-pivavarchyk volha-pivavarchyk commented Jul 14, 2023

Q A
Bug fix? (use the a.b branch) [✓]
New feature/enhancement? (use the a.x branch) [✗ ]
Deprecations? [ ✗ ]
BC breaks? (use the c.x branch) [✗ ]
Automated tests included? [✗ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

After migration to twig templates basic html code in form help text is not rendered.
image
It was added by PR #11335.

This PR fixes it.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create a new form.
  3. Add a help message formatted with html tags.
  4. Check if html code is rendered
  5. Add a help message with a dangerous tag, e.g. script
  6. Check if this tag is removed

image

@escopecz escopecz added bug Issues or PR's relating to bugs pending-feedback PR's and issues that are awaiting feedback from the author labels Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #12562 (90dece8) into 5.x (9a609d5) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12562      +/-   ##
============================================
+ Coverage     57.28%   57.35%   +0.07%     
- Complexity    33531    33533       +2     
============================================
  Files          2163     2163              
  Lines        101323   101330       +7     
============================================
+ Hits          58038    58119      +81     
+ Misses        43285    43211      -74     

see 10 files with indirect coverage changes

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Jul 19, 2023
@escopecz escopecz added this to the 5.0-beta milestone Jul 19, 2023
@escopecz escopecz merged commit 7e11003 into mautic:5.x Jul 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants