New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(phpstan): Remove deprecations related to execute\(\) method #12684
Conversation
f7a420f
to
9196c91
Compare
It looks like tests are now passing failing tests are now passing on my local. However I was unable to run all of them :( |
Thanks for the PR @scyzoryck and welcome to the community! I've set the automated test suite running, and will ping some of the developers to review your proposed changes! |
Thanks! I will rebase the branch & fix the last issues from tests later today :) |
9196c91
to
7c94d04
Compare
Codecov Report
@@ Coverage Diff @@
## 5.x #12684 +/- ##
============================================
- Coverage 58.49% 58.49% -0.01%
Complexity 33555 33555
============================================
Files 2177 2177
Lines 101591 101588 -3
============================================
- Hits 59423 59420 -3
Misses 42168 42168
|
7c94d04
to
c892e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this PR, it is good to go.
It was on my pipeline but never had the time to do it.
Thanks @scyzoryck this is a very strong start, we hope we can get more contribution from you
@scyzoryck Please fix |
c892e1a
to
cec28de
Compare
Thanks for feedback. Rebased & code style fixed. I need to finish setting up environment with docker to have all tests working on my local. :) Best, scyzoryck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the code changes and confirmed that the executeQuery
method is used for select queries and executeStatement
method for the insert, update and delete queries.
Since this PR touches every part of Mautic we must trust our test suite to scream if there is something wrong. And it's not screaming, so approving 👍
Description:
Hi! My first PR here.
Fixes for phpstan errors:
Steps to test this PR: