Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adding custom GrapeJS plugins to customize the editor #12692

Closed
wants to merge 1 commit into from

Conversation

irfanhanfi
Copy link

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Creating a clone PR of #12429 for Mautic 4.4

@escopecz
Copy link
Sponsor Member

escopecz commented Sep 6, 2023

I don't think this will be merged to Mautic 4. It's a feature and only bug and security fixes will be accepted for future Mautic 4 releases.

cc @mollux @RCheesley

@escopecz escopecz added the blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged) label Sep 6, 2023
@ekkeguembel
Copy link
Sponsor

That's ok, we can even close it. We decided to do the PR anyway, so people who are on m4 can take advantage of it by applying it as a patch.
And at the same time, some experience will be collected, including foundation for any discussion about having this feature in m5.
cc @mollux @RCheesley

@RCheesley
Copy link
Sponsor Member

Thanks for making the PR for Mautic 4 - let's close the PR as we won't be able to merge it, but it will be there as a reference point if people want this feature backported for their own instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something blocks this PR/issue (e.g. waiting for another PR to be merged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants