[DPMMA-2341] Fixed missing preference center #12829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annamunk
added
bug
mollux
requested changes
Oct 31, 2023
There was a problem hiding this comment.
while the code has the correct outcome, it differs from the approach in M4, see https://github.com/mautic/mautic/blob/4.4.10/app/bundles/EmailBundle/Views/Email/form.html.php#L224...L227
in M4 one of the 2 permissions was enough, in M5 both are needed
1 task
Co-authored-by: Mattias Michaux <mattias.michaux@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 5.x #12829 +/- ##
=========================================
Coverage 58.67% 58.68%
Complexity 33631 33631
=========================================
Files 2181 2181
Lines 101824 101824
=========================================
+ Hits 59750 59751 +1
+ Misses 42074 42073 -1 |
|
@mollux thanks for catching it! I commited the change. |
kuzmany
added
the
pending-test-confirmation
volha-pivavarchyk
approved these changes
Nov 4, 2023
kuzmany
added
ready-to-commit
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/announcing-the-mautic-5-release-candidate/29967/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to test this PR: