Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for extra rendered fields in the contact form #12848

Merged
merged 1 commit into from Oct 31, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Oct 31, 2023

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #12628

Description:

Fix for #12628

The company is rendered in 5.x as there was special logic in 4.4, that was not added with the twig migration.

I don't really agree with the approach in M4 to set fields rendered (a better solution is the skip the field in the controllers), but for minimal changes, I reproduced the same result in the twig template.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. create a new or edit an existing contact
  3. verify the are no extra fields appended to the end of the page

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #12848 (3b17964) into 5.x (69f3b0d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12848      +/-   ##
============================================
- Coverage     58.68%   58.68%   -0.01%     
  Complexity    33631    33631              
============================================
  Files          2181     2181              
  Lines        101824   101824              
============================================
- Hits          59752    59751       -1     
- Misses        42072    42073       +1     

see 1 file with indirect coverage changes

@mollux mollux mentioned this pull request Oct 31, 2023
1 task
@escopecz escopecz self-requested a review October 31, 2023 08:59
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflowing field is gone.

Before:
Screenshot 2023-10-31 at 09 58 47

After:
Screenshot 2023-10-31 at 10 00 01

Code change is OK 👍

@escopecz escopecz added bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity contacts Anything related to contacts labels Oct 31, 2023
@escopecz escopecz added this to the 5.0-Release Candidate-1 milestone Oct 31, 2023
@escopecz escopecz merged commit 280c314 into mautic:5.x Oct 31, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs contacts Anything related to contacts user-interface Anything related to appearance, layout, and interactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields on contact profile when editing escape the container
2 participants