New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix point tags triggering #12867
Fix point tags triggering #12867
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 5.x #12867 +/- ##
============================================
+ Coverage 58.13% 58.16% +0.02%
- Complexity 32962 32963 +1
============================================
Files 2181 2181
Lines 98714 98715 +1
============================================
+ Hits 57389 57419 +30
+ Misses 41325 41296 -29
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked just as described when tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and also checked that point groups works too.
Tag 3 is applied as expected, thanks for the PR @kuzmany 🚀
This pull request has been mentioned on Mautic Forums. There might be relevant details there: |
Description:
Noticed triggering tags after hit points does not work. The PR fixed it.
Steps to test this PR:
Minimum number of points
= 20 + add trigger action to addtag 1
and remove tag 2 and tag 3Minimum number of points
= 1 + add trigger action to addtag 2
and remove tag 1 and tag 3Minimum number of points
= 30 + add trigger action to addtag 3
and remove tag 1 and tag 2tag 3
assigned to contact. But it's not