Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix point tags triggering #12867

Merged
merged 3 commits into from Dec 19, 2023
Merged

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Nov 3, 2023

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Noticed triggering tags after hit points does not work. The PR fixed it.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create point trigger 1 with Minimum number of points = 20 + add trigger action to add tag 1 and remove tag 2 and tag 3
  3. Create point trigger 2 with Minimum number of points = 1 + add trigger action to add tag 2 and remove tag 1 and tag 3
  4. Create point trigger 3 with Minimum number of points = 30 + add trigger action to add tag 3 and remove tag 1 and tag 2
  5. Create form with change point action with 35 points
  6. Submit form
  7. You should see tag 3 assigned to contact. But it's not
  8. After PR should work properly

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #12867 (a624d17) into 5.x (a8838f8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12867      +/-   ##
============================================
+ Coverage     58.13%   58.16%   +0.02%     
- Complexity    32962    32963       +1     
============================================
  Files          2181     2181              
  Lines         98714    98715       +1     
============================================
+ Hits          57389    57419      +30     
+ Misses        41325    41296      -29     
Files Coverage Δ
...ndles/LeadBundle/EventListener/PointSubscriber.php 100.00% <100.00%> (ø)
...dles/PointBundle/Entity/TriggerEventRepository.php 64.06% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link

@PatrickJenkner PatrickJenkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked just as described when tested

@PatrickJenkner PatrickJenkner added pending-test-confirmation PR's that require one test before they can be merged points-scoring Anything related to points tags Anything relating to tags and removed ready-to-test PR's that are ready to test labels Nov 6, 2023
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and also checked that point groups works too.

Tag 3 is applied as expected, thanks for the PR @kuzmany 🚀

@RCheesley RCheesley added code-review-needed PR's that require a code review before merging user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Nov 10, 2023
@RCheesley RCheesley added this to the 5.0-General Availability milestone Nov 10, 2023
@mautibot
Copy link

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/post-thanksgiving-boost-contribute-to-mautic-this-open-source-friday/30038/1

@escopecz escopecz added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Dec 19, 2023
@escopecz escopecz added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Dec 19, 2023
@escopecz escopecz merged commit 9cce170 into mautic:5.x Dec 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review points-scoring Anything related to points ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged tags Anything relating to tags user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants