Adding VIEW_INJECT_CUSTOM_TEMPLATE back even in the Twig world #12924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: https://forum.mautic.org/t/what-is-mautic-5-way-of-injecting-custom-templates/29846/3 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 5.x #12924 +/- ##
============================================
+ Coverage 58.81% 58.85% +0.03%
- Complexity 33627 33628 +1
============================================
Files 2181 2181
Lines 101821 101826 +5
============================================
+ Hits 59889 59925 +36
+ Misses 41932 41901 -31
|
escopecz
added
regression
escopecz
force-pushed
the
fixing-VIEW_INJECT_CUSTOM_TEMPLATE-event
branch
from
c87fc08
to
ecda012
Compare
|
This pull request has been mentioned on Mautic Forums. There might be relevant details there: |
|
Hi @escopecz , I just did the basic test on this and it works OK. When I adjust the actual plugin and test it, I will make a review here.
You did something very valuable here, thank you. |
escopecz
added
user-testing-passed
kuzmany
added
ready-to-commit
escopecz
removed
the
code-review-needed
|
you beat me to the review, kuzmany, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
CoreEvents::VIEW_INJECT_CUSTOM_TEMPLATEevent used to be in the PhpEngine but was removed together with it.I found another place to put it to work as before even with the twig templates.
The IntegrationBundle actually used that event to display object mapping on the contact detail page, so that was broken.
Steps to test this PR:
CoreEvents::VIEW_INJECT_CUSTOM_TEMPLATEevent was removed together with the PhpEngine, this functionality stopped working.