Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Company Fields variables are not rendered when used in Dynamic Web Content #13198

Conversation

shinde-rahul
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 4.4
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #13125

Description:

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
    How can we reproduce this issue?
  2. Create a Company and fill out fields like phone, website etc.
  3. Create a contact and add the contact to the company
  4. Create a non-campaign-based DWC with a variable for a company field, e.g. {contactfield=companyphone} in the content. Add a filter that is fulfilled by the contact form Step 2 eg. Email = not empty
  5. Create a landing page and add the DWC to the LP
  6. Open the Landing page for the contact from Step 2 and see that no content is rendered.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (505a21c) 58.69% compared to head (e381c91) 58.69%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13198      +/-   ##
============================================
- Coverage     58.69%   58.69%   -0.01%     
- Complexity    33110    33111       +1     
============================================
  Files          2194     2194              
  Lines         99097    99099       +2     
============================================
+ Hits          58161    58162       +1     
- Misses        40936    40937       +1     
Files Coverage Δ
...tBundle/EventListener/DynamicContentSubscriber.php 85.71% <100.00%> (+0.42%) ⬆️
...pp/bundles/LeadBundle/Entity/CompanyRepository.php 57.84% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

@PatrickJenkner PatrickJenkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked just as described when tested 👍

@PatrickJenkner PatrickJenkner added bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged companies Anything related to companies contacts Anything related to contacts labels Jan 12, 2024
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Jan 12, 2024
@escopecz escopecz added this to the 5.1.0 milestone Jan 12, 2024
@escopecz escopecz merged commit 65421d2 into mautic:5.x Jan 12, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs companies Anything related to companies contacts Anything related to contacts ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M5: Company Fields variables are not rendered when used in Dynamic Web Content
4 participants