Add Missing Translations for GrapeJS #13207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
approved these changes
Jan 12, 2024
escopecz
added
bug
escopecz
added
the
pending-feedback
escopecz
approved these changes
Jan 15, 2024
escopecz
added
user-testing-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.0 #13207 +/- ##
=========================================
Coverage 58.59% 58.60%
- Complexity 32975 32985 +10
=========================================
Files 2181 2183 +2
Lines 98735 98756 +21
=========================================
+ Hits 57856 57877 +21
Misses 40879 40879 |
|
@escopecz line 21 and 25 use the same class. We should delete one |
|
OOps. I'll push the change. Thanks for checking! |
|
#13224 @code5rick can you please approve? |
|
@escopecz tested, and it is working perfectly! The previously missing labels are now fixed and functioning at 100% 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The new Mautic 5 comes with some minor changes to the GrapeJS builder, and some labels have been added. This PR addresses the issue #13098 and also resolves the absence of labels for the columns.
Note:
I have added the missing labels for the preview icon and the modal alert. However, I would recommend that someone review my PR to ensure that these two cases are handled correctly.