-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php 8.2 with new CS Fixer version #13212
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requiring iconv as it's used in other parts of the codebase without any check
…octrineStep::$host_ro is deprecated
…ed; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead
…lTest::$leadDeviceRepository is deprecated
… and it was a pain to debug it
…eLookup::$region_code is deprecated"
…dId is deprecated
…thod signature which is a BC break and the class is deprecated so it will go away in M6 anyway
escopecz
added
the
blocked
Something blocks this PR/issue (e.g. waiting for another PR to be merged)
label
Jan 12, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13212 +/- ##
============================================
- Coverage 58.69% 58.65% -0.04%
+ Complexity 33111 33110 -1
============================================
Files 2194 2194
Lines 99099 99092 -7
============================================
- Hits 58163 58127 -36
- Misses 40936 40965 +29
|
escopecz
added
ready-to-test
PR's that are ready to test
enhancement
Any improvement to an existing feature or functionality
needs-rebase
PR's that need to be rebased
and removed
blocked
Something blocks this PR/issue (e.g. waiting for another PR to be merged)
ready-to-test
PR's that are ready to test
labels
Feb 6, 2024
Closing in favor or #13637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Any improvement to an existing feature or functionality
needs-rebase
PR's that need to be rebased
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I'm pushing these changes here because I want to separate manual (#12469) changes with the automatic changes in this PR.
The reason for upgrade of the CS Fixer library is that on PHP 8.2 it throws this error:
There is a walk around solution suggested in the error message but I think it's time to update the CS Fixer. This PR contains only the changes generated by the new CS Fixer version.
Steps to test this PR: