Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replace entity with reference for detached lists for add to segment action #13244

Merged
merged 1 commit into from Jan 19, 2024

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jan 19, 2024

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

This PR fix issue:

A new entity was found through the relationship 'Mautic\\LeadBundle\\Entity\\ListLead#list' that was not configured to cascade persist operations for entity: Mautic\\LeadBundle\\Entity\\LeadList with ID #318.

If we trace it, It's coming on the large instance on campaign action add to segment.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. You can tast campaign action for add/remove contat from segments
  3. Otherwise code review is enought too

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff94aab) 58.59% compared to head (8499c5b) 58.60%.
Report is 38 commits behind head on 5.0.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.0   #13244   +/-   ##
=========================================
  Coverage     58.59%   58.60%           
- Complexity    32975    32985   +10     
=========================================
  Files          2181     2183    +2     
  Lines         98735    98756   +21     
=========================================
+ Hits          57856    57878   +22     
+ Misses        40879    40878    -1     
Files Coverage Δ
app/bundles/LeadBundle/Model/ListModel.php 62.90% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense and is a safer option to the original state. Thanks! 👍

@escopecz escopecz added this to the 5.0.3 milestone Jan 19, 2024
@escopecz escopecz added code-review-passed PRs which have passed code review campaigns Anything related to campaigns and campaign builder and removed ready-to-test PR's that are ready to test labels Jan 19, 2024
@escopecz escopecz merged commit bee6b30 into mautic:5.0 Jan 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs campaigns Anything related to campaigns and campaign builder code-review-passed PRs which have passed code review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants