New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix call to logger warn method. #13252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 🫰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdamBark while your change fixes that specific error on that specific place, there are 3 other occurrences around that code that use the same non-existing method.
Can you please address those too?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 5.0 #13252 +/- ##
============================================
- Coverage 58.60% 58.60% -0.01%
Complexity 32985 32985
============================================
Files 2183 2183
Lines 98756 98756
============================================
- Hits 57877 57876 -1
- Misses 40879 40880 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional changes!
@AdamBark I just noticed you made the PR against 5.x, and it should be 5.0, as it's a bugfix. Can you rebase your changes based on 5.0? then this PR can be merged |
Will do. I was a bit confused by the various documentations on which branch it should be on so thanks for the clarification. Perhaps this line "All PRs are made against the c.x branch in the first instance (e.g. 5.x)" should be amended? |
warn is not a method, warning appears to be correct.
warn is not a method, warning appears to be correct.
Description:
When running
bin/console mautic:iplookup:download
the following error is thrown without this bugfix if you have no credentials for the Maxmind service.Steps to test this PR:
php bin/console mautic:iplookup:download