Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect version of the SpBundle dependency #13253

Merged
merged 1 commit into from Jan 20, 2024
Merged

fix incorrect version of the SpBundle dependency #13253

merged 1 commit into from Jan 20, 2024

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Jan 20, 2024

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #13250

Description:

In #12797 and mautic/SpBundle#1 an Symfony incompatibility issue was fixed.
However, #12797 didn't fix the needed change in the composer.lock file, to link to the new version of the mautic/SpBundle.

This PR addresses this.

see https://github.com/mautic/SpBundle/commits/symfony5/

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@mollux mollux added this to the 5.0.3 milestone Jan 20, 2024
@mollux mollux mentioned this pull request Jan 20, 2024
Closed
1 task
@mollux mollux linked an issue Jan 20, 2024 that may be closed by this pull request
SAML SSO doesn't work in Mautic v5 #13250
Closed
1 task
@mollux mollux added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test composer Any bugs or PRs relating to composer labels Jan 20, 2024
escopecz
escopecz approved these changes Jan 20, 2024
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@escopecz escopecz merged commit efb9ac1 into mautic:5.0 Jan 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs composer Any bugs or PRs relating to composer ready-to-test PR's that are ready to test
Projects
Open Source Fridays
Archived in project
Milestone
5.0.3
Development

Successfully merging this pull request may close these issues.

SAML SSO doesn't work in Mautic v5
2 participants
@mollux @escopecz