Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect occurrences of dns where it should be dsn #13259

Merged
merged 1 commit into from Jan 25, 2024

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Jan 20, 2024

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

in code there are multiple occurences of dns, where it should be dsn.
This PR fixes this

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. ensure assets are regenerated, as there are changes to the source js files
  3. edit DSN settings for mailer and messenger via the UI, and verify all logic is still working

@mollux mollux added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jan 20, 2024
@mollux mollux added this to the 5.0.3 milestone Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (efb9ac1) 58.60% compared to head (366ab0c) 58.60%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.0   #13259   +/-   ##
=========================================
  Coverage     58.60%   58.60%           
  Complexity    32985    32985           
=========================================
  Files          2183     2183           
  Lines         98756    98756           
=========================================
  Hits          57877    57877           
  Misses        40879    40879           
Files Coverage Δ
app/bundles/ConfigBundle/Form/Type/DsnType.php 92.30% <100.00%> (ø)
...p/bundles/MessengerBundle/Form/Type/ConfigType.php 100.00% <100.00%> (ø)
...dles/MessengerBundle/Controller/AjaxController.php 0.00% <0.00%> (ø)
...les/MessengerBundle/MessageHandler/TestHandler.php 26.66% <0.00%> (ø)

Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good

Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Jan 21, 2024
@escopecz escopecz merged commit 1cb9d1f into mautic:5.0 Jan 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants