Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing filter on contact grid display #13260

Merged
merged 1 commit into from Jan 25, 2024
Merged

fix missing filter on contact grid display #13260

merged 1 commit into from Jan 25, 2024

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Jan 21, 2024

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

when switching from the default table to grid view on the contact overview page (/s/contacts), the filter above the results disappears.

This PR fixes this.

before
Screenshot 2024-01-21 at 09 13 54

after
Screenshot 2024-01-21 at 09 14 01

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. toggle between table and card mode using the t and g key
  3. verify the filters are there

@mollux mollux added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jan 21, 2024
@mollux mollux added this to the 5.0.3 milestone Jan 21, 2024
kuzmany
kuzmany approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 🫰
It works

@kuzmany kuzmany added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jan 21, 2024
escopecz
escopecz approved these changes Jan 25, 2024
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍

@escopecz escopecz merged commit 0f31906 into mautic:5.0 Jan 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged
Projects
Open Source Fridays
Archived in project
Milestone
5.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mollux @kuzmany @escopecz