Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user account tabs #13704

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix user account tabs #13704

merged 1 commit into from
May 3, 2024

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Apr 29, 2024 •
edited
Loading

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #13702

Description:

This PR removes a forgotten <div> to fix tabs issue.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Log in and edit your user account
  3. Try to change the fields
  4. Click authorized applications
  5. Notice you can do everything normally

@andersonjeccel andersonjeccel added the bug Issues or PR's relating to bugs label Apr 29, 2024
@RCheesley RCheesley added user-interface Anything related to appearance, layout, and interactivity roles Anything related to users and roles labels Apr 29, 2024
RCheesley
RCheesley approved these changes Apr 29, 2024
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy fix, confirm it resolves the issue entirely!

@RCheesley RCheesley added code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged T1 Low difficulty to fix (issue) or test (PR) labels Apr 29, 2024
@RCheesley RCheesley added this to the 5.1.0 milestone Apr 29, 2024
shinde-rahul
shinde-rahul approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Thanks @andersonjeccel!!!

@andersonjeccel andersonjeccel added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels May 3, 2024
@andersonjeccel andersonjeccel self-assigned this May 3, 2024
@escopecz escopecz merged commit 4f420ab into mautic:5.x May 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@shinde-rahul shinde-rahul shinde-rahul approved these changes

@RCheesley RCheesley RCheesley approved these changes

Assignees

@andersonjeccel andersonjeccel

Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review roles Anything related to users and roles T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Archived in project
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Unable to set various user profile fields in 5.x branch
5 participants
@andersonjeccel @kuzmany @shinde-rahul @RCheesley @escopecz