Returning custom field view permission

[escopecz]

Q	A
Bug fix? (use the a.b branch)	[y]
New feature/enhancement? (use the a.x branch)	[ ]
Deprecations?	[ ]
BC breaks? (use the c.x branch)	[ ]
Automated tests included?	[y]
Related user documentation PR URL	mautic/mautic-documentation#...
Related developer documentation PR URL	mautic/developer-documentation#...
Issue(s) addressed	Fixes #13602

Description:

This line got removed in https://github.com/mautic/mautic/pull/13321/files#diff-fc1c6863009fa9dbb412ad96ef474537d4e3d72c2ccc90f126e7bd808b0e45a7L64 by accident. Probably due to extensive conflicts when updating that PR and its predecessor to updated target branch.

Steps to test this PR:

1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
2. Follow the steps from Missing Custom fields view permission #13602

[RCheesley]

I checked out this PR but I'm still not seeing the view permission for this.

[escopecz]

Oops, I was so sure I found the problem. There was another line missing. Added that and then updated the existing test that confirms there are 2 permissions for the contact fields now.

[RCheesley]

Thanks @escopecz - when I try to view the custom fields logged in with a user who has 'view' permission:

I don't actually see it in the settings menu at all. I think that I should at least be able to view them?

[jos0405]

Custom fields are not visible yet.

[patrykgruszka]

Code looks fine 👍

Works well from API perspective - can get all custom fields with both - view or manage permissions.

The problem with accessing Mautic Panel custom fields with view-only permissions is also present in the 4.x version. So this issue is not a regression. In my opinion, it's good to go.

[escopecz]

Thanks for confirming. Since this fixes the regression described in #13602 I'm merging this to unblock the release of 5.1.0