-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Sidebars #13754
base: 5.x
Are you sure you want to change the base?
[UI] Sidebars #13754
Conversation
revert Revert "fixing broken darken/lighten" This reverts commit bcf4ac98e07c0c17162a74794a8161d5398c3d7c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuzmany I moved the Settings title to an accessible description for screen readers only Why to have a title on the right sidebar if we don’t have a title on the left? And the second sidebar is more than settings… How would a points group differ from a category? If one of them is a setting, the other also should be considered perhaps we can be a bit more reasonable for users going this way, what do you think? |
@andersonjeccel I've noticed the empty space. From a user's perspective, it appears to be a bug.I am not saying you need to fix it, just saying even if it fits all attributes, for basic users it could look like a bug in design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the sidebar collapsed the menu items like,
- Component
- Channels
- Points
They are inaccessible. Please check this,
video1500268263.mp4
@kuzmany I’m actually searching for perceptions like yours what if we had a toggle for dark mode there? Would you find it a strange place to be? my initial idea was to put the toggle on the account profile |
@shinde-rahul I’ll check it Do you know if this functionality works normally on other instances? |
@shinde-rahul Checked, it seems like an old issue |
How to test dark mode?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in both light and dark mode 👍
I agree with @kuzmany that the empty space in the right sidebar looks weird. I like your idea of putting the toggle for dark mode there. That would make it more easily accessible than putting it in the profile
Description
This PR is based on another PR, where I introduce tokens to replace most of the UI variables, aiming to improve consistency in all components. We need it to be merged before this one becomes available for code review.
This PR:
Before:
sidebars-before.mp4
After:
sidebars-after.mp4
📋 Steps to test this PR:
How to test dark mode?
document.documentElement.setAttribute('color-theme', 'dark');
and hit Enter