[UI] Remove all background color classes #13755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonjeccel
added
T1
PatrickJenkner
approved these changes
May 24, 2024
PatrickJenkner
added
pending-test-confirmation
escopecz
approved these changes
Jun 6, 2024
escopecz
added
code-review-passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all background classes to make sure everything will inherit the
<body>standard, increasing the compatibility with the dark theme, while simplifying our way of building the UI.It means we can improve consistency by defining properties according to the elements instead of using separate classes. It also makes easier to maintain the project, since new CSS features can handle different scenarios automatically. More focus on features, less focus on building the interface.
Tested all main pages, they seem fine.
馃搵 Steps to test this PR: