Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Account overview #13756

Draft
wants to merge 35 commits into
base: 5.x
Choose a base branch
from

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented May 15, 2024

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR is based on another PR, where I introduce tokens to replace most of the UI variables, aiming to improve consistency in all components. We need it to be merged before this one becomes available for code review.

This PR creates a user overview, where we can put toggles for dark theme and high contrast later.
It also indicates where to change profile picture (mautic is based on gravatar).

When someone has a profile pic in their Gravatar profile, it's shown here. The background is automatically created through a blur filter on top of an image copy, so colors combine and get harmonic etc.

image

Mobile:
image


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open top navbar > Account > See

revert
Revert "fixing broken darken/lighten"
This reverts commit bcf4ac98e07c0c17162a74794a8161d5398c3d7c.
@andersonjeccel andersonjeccel requested review from a team, ricfreire and Esthertests May 15, 2024 21:55
@andersonjeccel andersonjeccel self-assigned this May 15, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality labels May 15, 2024
Copy link
Contributor

@oltmanns-leuchtfeuer oltmanns-leuchtfeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat little feature, I quite like it. The only thing that I would propose to change is that the links to Gravatar should open in a separate tab. All changed made to my preferences where gone when I clicked on that link before hitting "Save".

@andersonjeccel
Copy link
Contributor Author

Makes sense, I’ll fix it soon!
Thanks for testing 🙏🏻

Copy link
Contributor

@LordRembo LordRembo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar remark I had on other PR's, but there's a lot of CSS changes in here that don't seem to fit with the goal/description of this 1 PR (eg. builder.css). If all you want to do is make changes to the background and a bit of groundwork (structure-wise) for later adding stuff, I think there's too much css changing.
These additions are also the same as in the other PR's, leading me to think they should be first done as part of one of the 'restructring' PR's or get the open PR's to do with colors, tokens, … merged first.

@andersonjeccel
Copy link
Contributor Author

@LordRembo Most of my UI pull requests are based on the branch about tokens, that’s why it appears to have a lot happening

If we change something there, I can just do a rebase

the main goal here is to let people see the expected changes and opine

@LordRembo
Copy link
Contributor

@andersonjeccel You shouldn't be making PR's that contain the content of another PR, until that one is merged. Especially one as big as the Tokens overhaul.
Working like this is extremely confusing, as people are asked to review a relatively small change while having to accept the major structural overhaul that is actually part of another PR.
I would advise to put all these PR's that depend on those changes, in Draft, and we can discuss what you are trying to achieve, to find a better way. Eg. at least these PR's should be marked as dependent or blocked on the Tokens PR

@andersonjeccel andersonjeccel marked this pull request as draft May 21, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality ready-to-test PR's that are ready to test T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants