-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Account overview #13756
base: 5.x
Are you sure you want to change the base?
[UI] Account overview #13756
Conversation
revert Revert "fixing broken darken/lighten" This reverts commit bcf4ac98e07c0c17162a74794a8161d5398c3d7c.
…rs' into ui-list-group-tabs-more-contrast
…rs' into ui-list-group-tabs-more-contrast
…rs' into ui-list-group-tabs-more-contrast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat little feature, I quite like it. The only thing that I would propose to change is that the links to Gravatar should open in a separate tab. All changed made to my preferences where gone when I clicked on that link before hitting "Save".
Makes sense, I’ll fix it soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A similar remark I had on other PR's, but there's a lot of CSS changes in here that don't seem to fit with the goal/description of this 1 PR (eg. builder.css). If all you want to do is make changes to the background and a bit of groundwork (structure-wise) for later adding stuff, I think there's too much css changing.
These additions are also the same as in the other PR's, leading me to think they should be first done as part of one of the 'restructring' PR's or get the open PR's to do with colors, tokens, … merged first.
@LordRembo Most of my UI pull requests are based on the branch about tokens, that’s why it appears to have a lot happening If we change something there, I can just do a rebase the main goal here is to let people see the expected changes and opine |
This reverts commit a8c4748.
…rs' into ui-account-overview
@andersonjeccel You shouldn't be making PR's that contain the content of another PR, until that one is merged. Especially one as big as the Tokens overhaul. |
Description
This PR is based on another PR, where I introduce tokens to replace most of the UI variables, aiming to improve consistency in all components. We need it to be merged before this one becomes available for code review.
This PR creates a user overview, where we can put toggles for dark theme and high contrast later.
It also indicates where to change profile picture (mautic is based on gravatar).
When someone has a profile pic in their Gravatar profile, it's shown here. The background is automatically created through a blur filter on top of an image copy, so colors combine and get harmonic etc.
Mobile:
📋 Steps to test this PR: