Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Remove ghost lines from background #13785

Merged
merged 1 commit into from
May 28, 2024

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR removes random lines on the background.

Before:
image

After:
image


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Assets > New > Have a look on the background

@andersonjeccel andersonjeccel self-assigned this May 27, 2024
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.93%. Comparing base (4014cba) to head (2e3ed13).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #13785      +/-   ##
============================================
- Coverage     61.93%   61.93%   -0.01%     
  Complexity    34195    34195              
============================================
  Files          2248     2248              
  Lines        102265   102265              
============================================
- Hits          63337    63336       -1     
- Misses        38928    38929       +1     

see 1 file with indirect coverage changes

Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to replicate the ghost line, but I don't see this change breaking anything either 👍

@escopecz escopecz added this to the 5.1.0 milestone May 28, 2024
@escopecz escopecz added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels May 28, 2024
@escopecz escopecz merged commit eeac671 into mautic:5.x May 28, 2024
15 of 16 checks passed
@andersonjeccel andersonjeccel deleted the ui-remove-ghost-lines branch July 15, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants