Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnClick event on color picker handeled differently so it works in FF #1962

Merged
merged 2 commits into from Jul 8, 2016

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Jul 6, 2016

Please answer the following questions:

Q A
Bug fix? Y
New feature? N
BC breaks? N
Deprecations? N
Fixed issues /

Description

  1. Section background options worked only on doubleclick in Firefox.
  2. Code view does not save the changes unless you switch back to editor first.

Steps to reproduce the bug (if applicable)

  1. Open the email or page builder in Firefox, highlight a section and try to change the background color.
  2. Try to change something in the code view, save. The change will be gone.

Steps to test this PR

Apply this PR and in dev mode or after rebuilding the assets and refreshing the browser try again.

@escopecz escopecz added T2 Medium difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Jul 6, 2016
@alanhartless alanhartless modified the milestone: 2.0.1 Jul 6, 2016
@escopecz escopecz mentioned this pull request Jul 8, 2016
@dongilbert
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test T2 Medium difficulty to fix (issue) or test (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants