Set roundmode on attribution field #1956 #1957

[wittwerch]

Please answer the following questions:

Q	A
Bug fix?	y
New feature?	n
BC breaks?	n
Deprecations?	n
Fixed issues	#1956 #1957

Description

The installer creates the lead fiels using Doctrine fixtures. The fixtures are missing the round mode for the new field attribution, which breaks the contact form.

Steps to reproduce the bug (if applicable)

Steps to test this PR

[escopecz]

Looks good. Are there any steps to replicate? I can edit contacts without any issue.

[wittwerch]

Yes, it only happens when you install Mautic 2.0 with the installer. Upgrading works, because the doctrine migration sets this value:

mautic/app/migrations/Version20160606000000.php

Line 44 in b704f42

(1,'Attribution', 'attribution', 'number', 'core', '0', 0, 1, 1, 0, 1, 0, 0, 23, 'a:2:{s:9:\"roundmode\";s:1:\"4\";s:9:\"precision\";s:1:\"2\";}'),

[mqueme]

I am unable to replicate. Can you explain how the form gets broken please.

[wittwerch]

1. Checkout release 2.0 from Github
2. Bootstrap using the installer
3. Go to Contacts -> New
4. Fill in firstname, lastname and e-mail
5. Click on "Save & Close"

Wheel keeps spinning forever. You get a HTTP 200 from the backend, but it contains the error message about the roundmode missing.

[escopecz]

I was able to replicate with the new installation like you said. The thing is that your fix will work for the new installations, but won't fix already installed Mautics 2.0.0. Would you mind to replace

https://github.com/mautic/mautic/blob/staging/app/bundles/LeadBundle/Form/Type/LeadType.php#L148

with

'rounding_mode' => isset($properties['roundmode']) ? (int) $properties['roundmode'] : 0

and add it to your PR?

[escopecz]

Thanks! As I'm looking at the code, we should probably unify the roundmode to 0 or 2. Not sure which should be the default. But that's just a minor issue. This PR is good to go by me 👍